WebReflection / lighterhtml

The hyperHTML strength & experience without its complexity 🎉
https://medium.com/@WebReflection/lit-html-vs-hyperhtml-vs-lighterhtml-c084abfe1285
ISC License
735 stars 20 forks source link

event bindings are not working properly #75

Closed KiranMantha closed 4 years ago

KiranMantha commented 4 years ago

event bindings are not working properly if there is class attribiute on node. Please find the screenshot of issue

image

In above image, my change event on dropdown is transformed to class attribute. I tried in multiple ways for binding but all is in vain. the issue can also be reproducable if the parent node has class attribute. Please help me on this.

yuretz commented 4 years ago

Well, I'm pretty sure, a screenshot is not enough for us to be able to help you. Could you maybe create a minimal reproduction example on CodePen / JsFiddle / something like this, so that we can see what's going on?

WebReflection commented 4 years ago

It makes no sense to show me the layout, I need to see what are you doing to create such layout.

I am closing this until there is something to investigate.

KiranMantha commented 4 years ago

Sorry for late reply. I'm writing a framework based on lighterhtml named plumejs. It is built using typescript. The below is a ui library built on top of plumejs. please find my repo here. please clone to your local and checkout to dev-branch.

npm start to run the application and you can find the above issue reproducable.

KiranMantha commented 4 years ago

when i downgraded domtagger version to 0.4.0 from 0.5.11 the issue is resolved. Don't know why the downgrade worked

WebReflection commented 4 years ago

Can you please provide a minimal example of a failing case? Cloning a whole project and investigate by myself is not how filing a bug works.

If you want me to understand any issue and fix it, I need you to help me out as much as you can.

Thank you.

WebReflection commented 4 years ago

Just FYI, I've written a guide on how to file issues https://medium.com/@WebReflection/how-to-file-a-github-lab-issue-7080b8c0cef5 and I hope it'll help you next time you have an issue here, or elsewhere.

KiranMantha commented 4 years ago

thankyou for providing conduct link. The problem is on my side as i'm using lighterhtml-plus but not lighterhtml which is causing compatability issue with latest domtagger version. When i used latest lighterhtml version, i didn't faced this issue . Sorry for troubling you for not providing a plunker or stackblitz link for reproduction and thanks for you paitience. :)

WebReflection commented 4 years ago

So, to clarify:

Is that correct? I admittedly moved forward lighterhtml without updating its counter part lighterhtml-plus, but I start thinking I should probably divide these two as separate repositories so that bugs can be filed independently, since these are indeed pretty different libraries.

KiranMantha commented 4 years ago

Exactly, there is no issue if i use lighterhtml with latest domtagger but if i use lighterhtml-plus with latest domtagger, i faced multiple issue like cloneNode of null or transforming events as classes. Seperating both of them is pretty good idea.

WebReflection commented 4 years ago

I've created a repository a part for lighterhtml-plus and it's literally copy and pasting lighterhtml just adding a patch on top.

The version has been updated, and my effort at maintaining the -plus version too minimized to the extreme (it's an npm run build away, nothing else).

I hope you won't have issues with that, as it uses already everything lighterhtml uses too 👋