search

WebReflection / linkedom

A triple-linked lists based DOM implementation.
https://webreflection.medium.com/linkedom-a-jsdom-alternative-53dd8f699311
ISC License
1.66k stars 80 forks source link

fix for attachShadow no longer adding childNodes to shadowRoot #211

Closed ttraenkler closed 1 year ago

ttraenkler commented 1 year ago

fix for #178: no longer adds the childNodes of the element to its shadowRoot when attaching a new shadowRoot

luwes commented 1 year ago

fixed this bug in my branch as well https://github.com/luwes/linkedom/commit/98f94da88ad69775cb92a5d394e0ea50a223b783

ttraenkler commented 1 year ago

@luwes Thanks! I see you also maintain work on improving shadow DOM support. Are you interested in collaborating on this? I am currently working on supporting element.getInnerHTML() https://github.com/WebReflection/linkedom/issues/210 and improved shadowRoot support here https://github.com/loopdive/linkedom which could be merged upstream once it's complete.

WebReflection commented 1 year ago

it's up and running

luwes commented 1 year ago

thanks @WebReflection!

@ttraenkler happy to collaborate on that.

The branch with most of my fixes and improvements are here https://github.com/luwes/linkedom/commits/wesc

It's for a project called WeSC https://github.com/luwes/wesc. One of the first goals is to add DSD easily in any project.