fix: getRootNode() bug - Githubissues

the <html> element is HTMLHtmlElement

getRootNode() returns

An object inheriting from Node. This will differ in exact form depending on where you called getRootNode(); for example:

Calling it on an element inside a standard web page will return an HTMLDocument object representing the entire page (or ).</li> <li>Calling it on an element inside a shadow DOM will return the associated ShadowRoot.</li> </ul> <hr /> <p>I ran in to this bug when calling getElementById on the root node but the method didn't exist with Linkedom. Code here <a rel="noreferrer nofollow" target="_blank" href="https://github.com/muxinc/media-chrome/blob/main/src/js/media-theme-element.js#L177-L178">https://github.com/muxinc/media-chrome/blob/main/src/js/media-theme-element.js#L177-L178</a></p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/WebReflection"><img src="https://avatars.githubusercontent.com/u/85749?v=4" />WebReflection</a> commented <strong> 1 year ago</strong> </div> <div class="markdown-body"> <p>This breaks <a href="https://github.com/WebReflection/linkedom/blob/e8dc9de5d4198382ae91c2bab18873c8c853812d/test/interface/text.js#L23">the test</a> which was already showing the <code>getRoot()</code> returns the <code>documentElement</code> so it's not clear what this fixes or why it's needed.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/luwes"><img src="https://avatars.githubusercontent.com/u/360826?v=4" />luwes</a> commented <strong> 1 year ago</strong> </div> <div class="markdown-body"> <p>^^ updated </p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/WebReflection"><img src="https://avatars.githubusercontent.com/u/85749?v=4" />WebReflection</a> commented <strong> 1 year ago</strong> </div> <div class="markdown-body"> <p>OK, thanks! this looks like an unintentional bug indeed ... however, code-coverage isn't super happy now ... mind trying to understand what's going on or why something is not covered?</p> <pre><code class="language-sh">npx c8 report --reporter=html</code></pre> <p>this should give you a <code>coverage/index.html</code> with all stats per file so you can see which one is not covered anymore or why.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/luwes"><img src="https://avatars.githubusercontent.com/u/360826?v=4" />luwes</a> commented <strong> 1 year ago</strong> </div> <div class="markdown-body"> <p>it has to do with the mutation observer tests it seems</p> <blockquote> <p>mutation-observer.js | 100 | 95 | 100 | 100 | 79-80</p> </blockquote> <p>maybe it needs <code>observed.getRootNode().documentElement</code> now?</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/WebReflection"><img src="https://avatars.githubusercontent.com/u/85749?v=4" />WebReflection</a> commented <strong> 1 year ago</strong> </div> <div class="markdown-body"> <p>it was passing through the <code>||</code> before, but it works as expected so we're good now ... it's up and running.</p> </div> </div> <div class="page-bar-simple"> </div> <div class="footer"> <ul class="body"> <li>© <script> document.write(new Date().getFullYear()) </script> Githubissues.</li> <li>Githubissues is a development platform for aggregating issues.</li> </ul> </div> <script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script> <script src="/githubissues/assets/js.js"></script> <script src="/githubissues/assets/markdown.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script> <script> hljs.highlightAll(); </script> </body> </html>

WebReflection / linkedom

fix: getRootNode() bug #213