search

WebReflection / linkedom

A triple-linked lists based DOM implementation.
https://webreflection.medium.com/linkedom-a-jsdom-alternative-53dd8f699311
ISC License
1.66k stars 80 forks source link

Add deep argument to the type of cloneNode() #222

Closed tai2 closed 11 months ago

tai2 commented 1 year ago

Node's cloneNode() should take the deep argument in type definition. Otherwise, other derived classes like Element also cannot take that parameter in TS.

WebReflection commented 11 months ago

to be honest, I am not sure this is a TS shenanigan but cloneNode already takes an optional argument ... I'll merge it, let's hope it will stay around ... if it doesn't, I am afraid I need to change the signature in the code, not in its .d.ts definition.