search

WebReflection / linkedom

A triple-linked lists based DOM implementation.
https://webreflection.medium.com/linkedom-a-jsdom-alternative-53dd8f699311
ISC License
1.69k stars 83 forks source link

List optional dependencies in `peerDependencies` + `peerDependenciesMeta` #249

Open moshest opened 11 months ago

moshest commented 11 months ago

For example in package.json:

{
  "name": "linkedom",
  "version": "0.16.1",
  "peerDependencies": {
    "canvas": ">= 2",
  },
  "peerDependenciesMeta": {
    "canvas": {
      "optional": true
    }
  }
}

Please see docs here: https://docs.npmjs.com/cli/v7/configuring-npm/package-json#peerdependenciesmeta

WebReflection commented 11 months ago

this "smells like a PR" 😄

jlara005 commented 1 month ago

When is a fix for the warnings going to be released? I'm on latest 0.18.5

WARNING in ./node_modules/linkedom/commonjs/perf_hooks.cjs 3:24-45 Module not found: Error: Can't resolve 'perf_hooks' in 'C:\Dev\TestProject\node_modules\linkedom\commonjs' @ ./node_modules/linkedom/cjs/interface/document.js 2:22-62 @ ./node_modules/linkedom/cjs/index.js 3:30-64

WebReflection commented 1 month ago

When is a fix for the warnings going to be released?

When the PR lands