Fix issue #260 escape for attributes in `XMLDocument`s - Githubissues

WebReflection / linkedom

A triple-linked lists based DOM implementation.

https://webreflection.medium.com/linkedom-a-jsdom-alternative-53dd8f699311

ISC License

1.71k stars 82 forks source link

Fix issue #260 escape for attributes in `XMLDocument`s #261

Closed omril1 closed 8 months ago

WebReflection commented 8 months ago

we're almost there ... code-coverage still not happy ... mind trying to make it happy? there are 6 cases:

it's HTML and
- the attribute is an empty known one and its value is not empty
- the attribute is an empty known one and its value is empty
- the attribute is not an empty one
it's XML and
- the attribute is an empty known one and its value is not empty
- the attribute is an empty known one and its value is empty
- the attribute is not an empty one

these should cover these changes and pass through all logic branches, if I haven't missed any other case, thanks!