WebReflection / usignal

A blend of @preact/signals-core and solid-js basic reactivity API
ISC License
221 stars 15 forks source link

Return type of effect #11

Closed benmerckx closed 2 years ago

benmerckx commented 2 years ago

The return type of effect is marked as void but the callback is returned, hence it probably should be typed as () => void

https://github.com/WebReflection/usignal/blob/a7d634a6bee97a9ffc334aa33c9f74c317df1c7b/esm/index.js#L141