WebReflection / usignal

A blend of @preact/signals-core and solid-js basic reactivity API
ISC License
220 stars 15 forks source link

fix: test and fix types #25

Closed qwelias closed 1 year ago

qwelias commented 1 year ago
WebReflection commented 1 year ago

beside conflicts with what's in the main, I am not sure why changes to the code are landing ... it's OK for the String(this.value) but the rest looks off, specially added peek() for the computed which should've been covered already and it's inherited like it is in signals

qwelias commented 1 year ago

Separated import fix https://github.com/WebReflection/usignal/pull/26

WebReflection commented 1 year ago

tests failing now

WebReflection commented 1 year ago

I've merged the other ... let's see how this goes but it need a rebase from main

qwelias commented 1 year ago

I have removed all changes aside the types test for now, which need to be fixed

Before i can fix them i need an answer here as i cannot understand it

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 4179925426


Totals Coverage Status
Change from base Build 4171654296: 0.0%
Covered Lines: 329
Relevant Lines: 329

💛 - Coveralls
qwelias commented 1 year ago

@WebReflection did I miss anything?