Closed qwelias closed 1 year ago
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Totals | |
---|---|
Change from base Build 4182430044: | 0.0% |
Covered Lines: | 341 |
Relevant Lines: | 341 |
so many PRs around the same topic ... are you able to actually test stuff before I keep publishing on npm? I am learning a lot from these PRs but it feels like we keep not getting at the intended result ... hence my question, not a blocker and definitively nothing against your contribution, rather personal curiosity on why these keep getting caught way too late in the pipe, thanks.
There was a number of compound problems. Improvements are made a few steps at a time because it's hard to make sense of loosely/mis-typed codebase.
I appreciate your work and am thinking (in case of more type problems) on refactoring it onto strict TS to have correct types out of the box instead of patching things here and there using JSDoc
that's probably worth for TS only users, but I am afraid my modules will always be JS unless next job hires me to write TS only code 😅
thanks for the explanation though, appreciated 👋
because
Signal
can be used forinstanceof
checks, but not for describing return types of eithersignal
orcomputed