Non adoptable <textarea> / <style>

WebReflection / viperHTML

Isomorphic hyperHTML

ISC License

314 stars 10 forks source link

Non adoptable <textarea> / <style> #22

Closed WebReflection closed 4 years ago

WebReflection commented 6 years ago

These two elements don't work well at all with adoptable layout.

It shouldn't really be a common case, and both works well without content, but adoptable should never put comments inside these elements when there is an interpolation.

Possible fix: when updates are created, somehow mark the one related to the interpolation inside textarea or style and do not put the comment in there

joshgillies commented 6 years ago

Would it be too much of a hack to use a data attribute as a way to mark adoptable content inside one of these element types?

WebReflection commented 6 years ago

just to clarify:

hyperHTML adopt is not released so this bug is absolutely irrelevant right now for both projects (so time to get it right is abundant)
the issue is with template literals placeholders that gets wrapped. Moving placeholders from a template tag signature is a whole new world of mess I don't even want to think about
it's not trivial ... it's not by accident it's taking me ages to get adoptable content right :sob:

thanks for the hint regardless

joshgillies commented 6 years ago

Moving placeholders from a template tag signature is a whole new world of mess I don't even want to think about

Haha, of course! I hadn't considered the ramifications of adopting new core logic on-top of the template tag interpretations in order to facilitate adopting content based off data attribute. Hrmmm, back to the drawing board.

WebReflection commented 4 years ago

As the adoption never landed, and as it's overly complicated and slow compared to solutions such as heresy, I am closing this as won't fix.