WebReflection / vscode-literally-html

Adds syntax highlighting for html inside of JavaScript and TypeScript tagged template strings
https://marketplace.visualstudio.com/items?itemName=webreflection.literally-html
MIT License
34 stars 6 forks source link

Handle Generic Tagged Template Functions #15

Closed EisenbergEffect closed 4 years ago

EisenbergEffect commented 4 years ago

Love this plugin and love the fact that it's being built in a library-agnostic way 😄

On that note, our html tag accepts generics when used with TypeScript. For example:

const template = html<MyElement>`
  some html goes here
`;

When the generic args (<MyElement>) are added, the plugin no longer recognizes the following string as HTML 😢

Is this something that can easily be fixed? I'd be happy to make a contribution if you can point me to the right place.

Thanks!

WebReflection commented 4 years ago

due vs code market place absurd flow, I had to drop the previous version and upload from scratch the new one. This issue should've been solved.

EisenbergEffect commented 4 years ago

Thanks for addressing that so quick! 😄