WebTheoryLLC / omniauth-twitch

OmniAuth Strategy for Twitch
MIT License
32 stars 22 forks source link

Need to update this thing to v5 of the API #10

Closed sithtoast closed 6 years ago

sithtoast commented 7 years ago

that shouldn't be too hard, right?

ossareh commented 7 years ago

@sithtoast have you researched this? As I understand the code I think it's good to go:

Am I missing something?

ossareh commented 7 years ago

Supporting docs for "get the default if you don't ask for a version": https://github.com/justintv/Twitch-API#api-versions-and-mime-types

That said, it might be a really solid idea to explicitly request a version :)

fx commented 7 years ago

@ossareh HeyGuys

I'll make sure this works and update here or submit a PR :)

jcgertig commented 7 years ago

Yeah @ossareh I had been looking into that but had not gotten to it yet @fx that would great