search

WebTheoryLLC / omniauth-twitch

OmniAuth Strategy for Twitch
MIT License
32 stars 22 forks source link

let callback_url return configured redirect_uri if present #8

Closed fx closed 8 years ago

fx commented 8 years ago

https://github.com/WebTheoryLLC/omniauth-twitch/pull/5 only affects authorize_params, but omniauth-oauth2 also sets redirect_uri in build_access_token (https://github.com/intridea/omniauth-oauth2/blob/master/lib/omniauth/strategies/oauth2.rb#L89)

It uses callback_url in both spots, which you overwrite already. So the sensible thing to do here would be to just let the generated value be overriden by what we've set in redirect_uri

jcgertig commented 8 years ago

My bad looks like I am not following this will look into this in just a bit in my phone now