Closed rzr closed 6 years ago
@rzr I intended for it to be installed in the home directory, rather than conflict with the gateway's own package.json
. It's not a big deal if it can't be saved to /home/node/package.json
, as yarn will still work just fine. Your log shows that yarn
is running just fine.
OK I think I faced a bigger problem I will update PR eventually
With this change: https://github.com/mozilla-iot/gateway/pull/1260
I noticed that wpa-supplicant was missing I will replace this PR once everything is checked.
We just need to run the gateway without the --check-wifi
flag.
Ok so the change should be in runapp.sh ? I am trying this too
Yes, either that or we need a separate startup script.
Is there any reason you don't want to use yarn start
here? The way I see it run-app.sh is the script for running on a real production device. My main question would be if there's ever a case when you'd want to OTA upgrade a docker-based installation, because then using run-app.sh would be reasonable.
yarn start
is probably sufficient, with a log redirect. I plan on building and releasing an 0.5 image when I'm back in a couple weeks.
I'll be back in 1 week too, maybe I could add a couple of changes more but it's not critical
@mrstegeman beware @hobinjk might drop yarn support, can we just rely on NPM ?
That shouldn't be a problem. I'll tackle it when necessary.
@rzr The potential dropping of yarn support is very far in the future since it would require changing a significant amount of our build scripts. It's definitely not something that will happen soon enough to impact this PR
yarn failed to install and thus failed to install gateway dependencies, to we relocate it to let it find gateway's package.json file.
Observed (silent) issue on docker 17.12.1-ce (Ubuntu-18.04) on x86_64:
Change-Id: I8737dfc28da8c8bf266de829725f3c09f62d9468 Signed-off-by: Philippe Coval p.coval@samsung.com