search

WebThingsIO / gateway

WebThings Gateway - a self-hosted web application for monitoring and controlling a building over the web
http://webthings.io/gateway
Mozilla Public License 2.0
2.61k stars 339 forks source link

strict mode: missing type "object" for keyword "properties" #2887

Open jcherrabi opened 3 years ago

jcherrabi commented 3 years ago

Hello guys, anyone know what this warning and sometime error is : 2021-11-04 16:34:58.024 WARN : strict mode: missing type "object" for keyword "properties" at "https://raw.githubusercontent.com/WebThingsIO/gateway-addon-ipc-schema/master/messages/definitions.json#/allOf/1" (strictTypes) using the latest clone from master. image

and when you add any addon it shows this:

image

createcandle commented 2 years ago

I see this too. About 12 of these lines:

WARN   : strict mode: missing type "object" for keyword "properties" at "https://raw.githubusercontent.com/WebThingsIO/gateway-addon-ipc-schema/master/messages/definitions.json#/allOf/1" (strictTypes)
LiberalArtist commented 2 years ago

I'm also seeing this. Would it be related to https://github.com/WebThingsIO/gateway/pull/2811#issuecomment-836527720, or is this a different sense of the word "property"? I'm new to webthings and have been shaving a lot of yacks, so it could be something else, but it seems like this is related to "no property found" messages I get from the zwave-addon (which has detected the light switch, but won't let me interact with it.

Here's what I'm seeing when I start the server, with many redundant lines clipped to keep this at least in the same universe as reasonable:

$ node build/app.js
Opening database: /home/philip/.webthings/config/db.sqlite3
2021-12-04 17:19:51.233 INFO   : Opening database: /home/philip/.webthings/log/logs.sqlite3
2021-12-04 17:19:51.293 INFO   : HTTPS server listening on port 4443
2021-12-04 17:19:51.294 INFO   : Redirector listening on port 8080
2021-12-04 17:19:51.301 DEBUG  : Ignoring https://raw.githubusercontent.com/WebThingsIO/gateway-addon-ipc-schema/master/schema.json because it has no messageType
2021-12-04 17:19:51.481 DEBUG  : Ignoring https://raw.githubusercontent.com/WebThingsIO/gateway-addon-ipc-schema/master/messages/definitions.json because it has no messageType
2021-12-04 17:19:51.501 WARN   : strict mode: missing type "object" for keyword "properties" at "https://raw.githubusercontent.com/WebThingsIO/gateway-addon-ipc-schema/master/messages/definitions.json#/allOf/1" (strictTypes)
2021-12-04 17:19:51.504 WARN   : strict mode: missing type "object" for keyword "properties" at "https://raw.githubusercontent.com/WebThingsIO/gateway-addon-ipc-schema/master/messages/definitions.json#/allOf/1" (strictTypes)
2021-12-04 17:19:51.509 WARN   : strict mode: missing type "object" for keyword "properties" at "https://raw.githubusercontent.com/WebThingsIO/gateway-addon-ipc-schema/master/messages/definitions.json#/allOf/1" (strictTypes)
2021-12-04 17:19:51.654 WARN   : strict mode: missing type "object" for keyword "properties" at "https://raw.githubusercontent.com/WebThingsIO/gateway-addon-ipc-schema/master/messages/definitions.json#/allOf/1" (strictTypes)
2021-12-04 17:19:51.804 INFO   : Loading add-on: zwave-adapter
2021-12-04 17:19:52.021 INFO   : zwave-adapter: Opening database: /home/philip/.webthings/config/db.sqlite3
2021-12-04 17:19:52.027 INFO   : zwave-adapter: Ignoring https://raw.githubusercontent.com/WebThingsIO/gateway-addon-ipc-schema/master/schema.json because it has no messageType
2021-12-04 17:19:52.189 INFO   : zwave-adapter: Ignoring https://raw.githubusercontent.com/WebThingsIO/gateway-addon-ipc-schema/master/messages/definitions.json because it has no messageType
2021-12-04 17:19:52.209 ERROR  : zwave-adapter: strict mode: missing type "object" for keyword "properties" at "https://raw.githubusercontent.com/WebThingsIO/gateway-addon-ipc-schema/master/messages/definitions.json#/allOf/1" (strictTypes)
2021-12-04 17:19:52.212 ERROR  : zwave-adapter: strict mode: missing type "object" for keyword "properties" at "https://raw.githubusercontent.com/WebThingsIO/gateway-addon-ipc-schema/master/messages/definitions.json#/allOf/1" (strictTypes)
2021-12-04 17:19:52.368 ERROR  : zwave-adapter: strict mode: missing type "object" for keyword "properties" at "https://raw.githubusercontent.com/WebThingsIO/gateway-addon-ipc-schema/master/messages/definitions.json#/allOf/1" (strictTypes)
2021-12-04 17:19:52.370 ERROR  : zwave-adapter: strict mode: missing type "object" for keyword "properties" at "https://raw.githubusercontent.com/WebThingsIO/gateway-addon-ipc-schema/master/messages/definitions.json#/allOf/1" (strictTypes)
2021-12-04 17:19:52.372 ERROR  : zwave-adapter: strict mode: missing type "object" for keyword "properties" at "https://raw.githubusercontent.com/WebThingsIO/gateway-addon-ipc-schema/master/messages/definitions.json#/allOf/1" (strictTypes)
2021-12-04 17:19:52.521 INFO   : zwave-adapter: Loading add-on zwave-adapter from /home/philip/.webthings/addons/zwave-adapter
2021-12-04 17:19:59.096 INFO   : zwave-adapter: DEBUG config = ''
2021-12-04 17:19:59.106 INFO   : zwave-adapter: Closing database
2021-12-04 17:19:59.270 INFO   : zwave-adapter: Found ZWave port @ /dev/ttyACM0
2021-12-04 17:19:59.271 INFO   : zwave-adapter: Initialising OpenZWave 1.6.0 binary addon for Node.JS.
2021-12-04 17:19:59.271 INFO   : zwave-adapter:         OpenZWave Security API is ENABLED
2021-12-04 17:19:59.272 INFO   : zwave-adapter:         ZWave device db    : /gnu/store/941q8sjw4xb6ma57q70d3a88r157yx9x-open-zwave-1.6/etc/openzwave
2021-12-04 17:19:59.272 INFO   : zwave-adapter:         User settings path : /home/philip/.webthings/data/zwave-adapter
2021-12-04 17:19:59.272 INFO   : zwave-adapter:         Option Overrides : --SaveConfiguration true --ConsoleOutput false
2021-12-04 17:20:00.017 INFO   : zwave-adapter: Driver Ready: HomeId: e9fc6ed0
2021-12-04 17:20:00.022 INFO   : zwave-adapter: node1: Named AEON Labs ZW090 Z-Stick Gen5 EU
2021-12-04 17:20:00.022 INFO   : zwave-adapter: node1: name="", type="Static PC Controller", location=""
2021-12-04 17:20:00.024 INFO   : zwave-adapter: node3 valueAdded: 3-38-1-6:Step Size = 0
2021-12-04 17:20:00.024 INFO   : zwave-adapter: node3 valueAdded: 3-38-1-7:Inc = undefined
2021-12-04 17:20:00.025 INFO   : zwave-adapter: node3 valueAdded: 3-38-1-8:Dec = undefined
2021-12-04 17:20:00.025 INFO   : zwave-adapter: node3 valueAdded: 3-38-1-0:Level = 0
2021-12-04 17:20:00.031 INFO   : zwave-adapter: node7 valueAdded: 7-135-1-0:Indicator = 0
2021-12-04 17:20:00.032 INFO   : zwave-adapter: node7: Named Unknown: id=0063 Unknown: id=0063 Unknown: type=4944, id=3333
2021-12-04 17:20:00.032 INFO   : zwave-adapter: node7: name="zwave-e9fc6ed0-7-Step Size", type="Light Dimmer Switch", location=""
2021-12-04 17:20:01.823 INFO   : Checking for add-on updates...
2021-12-04 17:20:03.447 INFO   : Finished updating add-ons
2021-12-04 17:20:12.341 INFO   : zwave-adapter: node8: node sleep
2021-12-04 17:20:14.150 INFO   : zwave-adapter: node3 valueChanged: 3-115-1-0:Powerlevel = Normal dB (no property found)
2021-12-04 17:20:14.150 INFO   : zwave-adapter: node3 valueChanged: 3-115-1-1:Timeout = 0 seconds (no property found)
2021-12-04 17:20:14.198 INFO   : zwave-adapter: node3 valueChanged: 3-38-1-0:Level = 0 (no property found)
2021-12-04 17:20:14.199 INFO   : zwave-adapter: node3 valueChanged: 3-38-1-9:Target Value = 0 (no property found)
2021-12-04 17:20:14.199 INFO   : zwave-adapter: node3 valueChanged: 3-38-1-5:Dimming Duration = 0 (no property found)
2021-12-04 17:20:14.288 INFO   : zwave-adapter: node3 valueChanged: 3-135-1-0:Indicator = 0 (no property found)
2021-12-04 17:20:15.537 INFO   : zwave-adapter: node4 valueChanged: 4-115-1-0:Powerlevel = Normal dB (no property found)
2021-12-04 17:20:15.538 INFO   : zwave-adapter: node4 valueChanged: 4-115-1-1:Timeout = 0 seconds (no property found)
2021-12-04 17:20:16.226 INFO   : zwave-adapter: node4 valueChanged: 4-38-1-0:Level = 0 (no property found)
2021-12-04 17:20:20.776 INFO   : zwave-adapter: node7 valueChanged: 7-38-1-5:Dimming Duration = 0 (no property found)
2021-12-04 17:20:21.124 INFO   : zwave-adapter: node7 valueChanged: 7-135-1-0:Indicator = 0 (no property found)
2021-12-04 17:20:21.126 INFO   : zwave-adapter: binarySwitchValueId = undefined levelValueId = 3-38-1-0 suffix = 
2021-12-04 17:20:21.131 INFO   : zwave-adapter: binarySwitchValueId = undefined levelValueId = 4-38-1-0 suffix = 
2021-12-04 17:20:21.131 INFO   : zwave-adapter: binarySwitchValueId = undefined levelValueId = 5-38-1-0 suffix = 
2021-12-04 17:20:21.132 INFO   : zwave-adapter: binarySwitchValueId = undefined levelValueId = 6-38-1-0 suffix = 
2021-12-04 17:20:21.136 INFO   : zwave-adapter: binarySwitchValueId = undefined levelValueId = 7-38-1-0 suffix = 
2021-12-04 17:20:21.136 INFO   : zwave-adapter: Scan complete
2021-12-04 17:20:21.136 INFO   : zwave-adapter: Controller: zwave-e9fc6ed0 Path: /dev/ttyACM0
2021-12-04 17:20:21.137 INFO   : zwave-adapter: Node LastStat Basic Type       Generic Type        Spec Product Name                             Name                          
2021-12-04 17:20:21.137 INFO   : zwave-adapter: ---- -------- ---------------- ------------------- ---- ---------------------------------------- ------------------------------
2021-12-04 17:20:21.137 INFO   : zwave-adapter:   1: ready    StaticController Static Controller   0x1  ZW090 Z-Stick Gen5 EU                                                  
2021-12-04 17:20:21.137 INFO   : zwave-adapter:   3: ready    RoutingSlave     Switch MultiLevel   0x0  Unknown: id=0063 Unknown: type=4944, id= zwave-e9fc6ed0-3-Step Size    
2021-12-04 17:20:21.137 INFO   : zwave-adapter:   4: ready    RoutingSlave     Switch MultiLevel   0x0  Unknown: id=0063 Unknown: type=4944, id= zwave-e9fc6ed0-4-Step Size    
2021-12-04 17:20:21.137 INFO   : zwave-adapter:   5: ready    RoutingSlave     Switch MultiLevel   0x0  Unknown: id=0063 Unknown: type=4944, id= zwave-e9fc6ed0-5-Step Size    
2021-12-04 17:20:21.137 INFO   : zwave-adapter:   6: ready    RoutingSlave     Switch MultiLevel   0x0  Unknown: id=0063 Unknown: type=4944, id= zwave-e9fc6ed0-6-Step Size    
2021-12-04 17:20:21.137 INFO   : zwave-adapter:   7: ready    RoutingSlave     Switch MultiLevel   0x0  Unknown: id=0063 Unknown: type=4944, id= zwave-e9fc6ed0-7-Step Size    
2021-12-04 17:20:21.137 INFO   : zwave-adapter:   8: sleeping RoutingSlave     Wall Controller     0x0                                           zwave-e9fc6ed0-8-button       
2021-12-04 17:20:21.138 INFO   : zwave-adapter: ----
2021-12-04 17:20:21.346 INFO   : zwave-adapter: node3 valueChanged: 3-38-1-0:Level property: on = false
2021-12-04 17:20:21.347 INFO   : zwave-adapter: node3 valueChanged: 3-38-1-0:Level property: level = 0.0% (zw: 0)
2021-12-04 17:20:21.347 INFO   : zwave-adapter: node3 valueChanged: 3-38-1-9:Target Value = 0 (no property found)
2021-12-04 17:20:21.347 INFO   : zwave-adapter: node3 valueChanged: 3-38-1-5:Dimming Duration = 0 (no property found)
2021-12-04 17:20:28.061 INFO   : zwave-adapter: node4 valueChanged: 4-38-1-0:Level property: on = false
2021-12-04 17:20:28.062 INFO   : zwave-adapter: node4 valueChanged: 4-38-1-0:Level property: level = 0.0% (zw: 0)
2021-12-04 17:20:28.062 INFO   : zwave-adapter: node4 valueChanged: 4-38-1-9:Target Value = 0 (no property found)
2021-12-04 17:21:56.599 INFO   : zwave-adapter: node3 valueChanged: 3-38-1-0:Level property: on = false
2021-12-04 17:21:56.599 INFO   : zwave-adapter: node3 valueChanged: 3-38-1-0:Level property: level = 0.0% (zw: 0)
2021-12-04 17:21:56.599 INFO   : zwave-adapter: node3 valueChanged: 3-38-1-9:Target Value = 0 (no property found)
2021-12-04 17:21:56.599 INFO   : zwave-adapter: node3 valueChanged: 3-38-1-5:Dimming Duration = 0 (no property found)
2021-12-04 17:22:12.602 INFO   : zwave-adapter: node4: timeout
2021-12-04 17:22:18.876 INFO   : zwave-adapter: node5 valueChanged: 5-38-1-0:Level property: on = false
2021-12-04 17:22:18.876 INFO   : zwave-adapter: node5 valueChanged: 5-38-1-0:Level property: level = 0.0% (zw: 0)
LiberalArtist commented 2 years ago

For me, at least, this seems to be working at 1.0.0 and at least through 6ce085adfb252f59c17db0ed70171af67d52fc93; but it is broken by 9ae796e59733c11a39fdb99cfa0e157ef4a6df89. I'll update this if I bisect any further.

LucasFerrazBR commented 2 years ago

I'm having this problem too, how can i fix it?

benfrancis commented 1 year ago

I think it means that the adapter add-on is sending an IPC message to the gateway which doesn't match the expected format. Specifically, a member called "properties" does not have the type "object". Whatever message the adapter is sending may be failing to validate against this line in the JSON schema, but I'm not sure why.

I think it is expecting the properties member of a Thing Description to be an object, but getting something other than an object.

I don't think this is actually a functional bug just a strict validation error, but it would be good to figure out if there's a problem with the schema or the messages being sent by adapters.