dilyn-corner
commented
1 month ago That's interesting. I'm not familiar enough with Node or JS to explain how that's the case.
For instance, there are a lot of these types of messages when building:
:: npm WARN notsup Unsupported engine for express-fileupload@1.5.1: wanted: {"node":">=12.0.0"} (current: {"node":"10.24.1","npm":"6.14.12"})
:: npm WARN notsup Not compatible with your version of node/npm: express-fileupload@1.5.1
:: npm WARN notsup Unsupported engine for tmp@0.2.3: wanted: {"node":">=14.14"} (current: {"node":"10.24.1","npm":"6.14.12"})
:: npm WARN notsup Not compatible with your version of node/npm: tmp@0.2.3
:: npm WARN notsup Unsupported engine for web-push@3.6.7: wanted: {"node":">= 16"} (current: {"node":"10.24.1","npm":"6.14.12"})
:: npm WARN notsup Not compatible with your version of node/npm: web-push@3.6.7
:: npm WARN notsup Unsupported engine for winston@3.15.0: wanted: {"node":">= 12.0.0"} (current: {"node":"10.24.1","npm":"6.14.12"})
:: npm WARN notsup Not compatible with your version of node/npm: winston@3.15.0
:: npm WARN notsup Unsupported engine for npmlog@6.0.2: wanted: {"node":"^12.13.0 || ^14.15.0 || >=16.0.0"} (current: {"node":"10.24.1","npm":"6.14.12"})
:: npm WARN notsup Not compatible with your version of node/npm: npmlog@6.0.2
:: npm WARN notsup Unsupported engine for ip-address@9.0.5: wanted: {"node":">= 12"} (current: {"node":"10.24.1","npm":"6.14.12"})
:: npm WARN notsup Not compatible with your version of node/npm: ip-address@9.0.5
:: npm WARN notsup Unsupported engine for are-we-there-yet@3.0.1: wanted: {"node":"^12.13.0 || ^14.15.0 || >=16.0.0"} (current: {"node":"10.24.1","npm":"6.14.12"})
:: npm WARN notsup Not compatible with your version of node/npm: are-we-there-yet@3.0.1
:: npm WARN notsup Unsupported engine for gauge@4.0.4: wanted: {"node":"^12.13.0 || ^14.15.0 || >=16.0.0"} (current: {"node":"10.24.1","npm":"6.14.12"})
:: npm WARN notsup Not compatible with your version of node/npm: gauge@4.0.4
:: npm WARN notsup Unsupported engine for https-proxy-agent@7.0.5: wanted: {"node":">= 14"} (current: {"node":"10.24.1","npm":"6.14.12"})
:: npm WARN notsup Not compatible with your version of node/npm: https-proxy-agent@7.0.5
:: npm WARN notsup Unsupported engine for http_ece@1.2.0: wanted: {"node":">=16"} (current: {"node":"10.24.1","npm":"6.14.12"})
:: npm WARN notsup Not compatible with your version of node/npm: http_ece@1.2.0
:: npm WARN notsup Unsupported engine for agent-base@7.1.1: wanted: {"node":">= 14"} (current: {"node":"10.24.1","npm":"6.14.12"})
:: npm WARN notsup Not compatible with your version of node/npm: agent-base@7.1.1
:: npm WARN notsup Unsupported engine for triple-beam@1.4.1: wanted: {"node":">= 14.0.0"} (current: {"node":"10.24.1","npm":"6.14.12"})
:: npm WARN notsup Not compatible with your version of node/npm: triple-beam@1.4.1
:: npm WARN notsup Unsupported engine for winston-transport@4.8.0: wanted: {"node":">= 12.0.0"} (current: {"node":"10.24.1","npm":"6.14.12"})
:: npm WARN notsup Not compatible with your version of node/npm: winston-transport@4.8.0
:: npm WARN notsup Unsupported engine for logform@2.6.1: wanted: {"node":">= 12.0.0"} (current: {"node":"10.24.1","npm":"6.14.12"})
:: npm WARN notsup Not compatible with your version of node/npm: logform@2.6.1
:: npm WARN notsup Unsupported engine for readable-stream@4.5.2: wanted: {"node":"^12.22.0 || ^14.17.0 || >=16.0.0"} (current: {"node":"10.24.1","npm":"6.14.12"})
:: npm WARN notsup Not compatible with your version of node/npm: readable-stream@4.5.2 
benfrancis
Done! 🫡
Closes #3171 Closes #3167
That's interesting. I'm not familiar enough with Node or JS to explain how that's the case.
They shouldn't be different. How are you building the snap locally? I'm building with snapcraft 8.x (various versions) with
--use-lxd, I'm trying now with snapcraft 7.5.5 in a Jammy container with--destructive-modeto compare.(Just ran a build in a Jammy LXD container using snapcraft 7.5.5 with
snapcraft --destructive-modeand installed the snap with--dangerous, I get the same error message of2024-10-08T21:39:41Z webthings-gateway.webthings-gateway[4792]: ReferenceError: globalThis is not defined).The build environment shouldn't really impact this, as this is a runtime problem; indeed, this problem should have always existed, as snapcraft will always fetch the node version you specify (as part of the npm plugin).
Indeed it is!
Does this mean that you are building with
--destructive-mode?The real reason the failure happens is if you build, don't clean, and attempt a rebuild; the file already exists in the target location, and for some reason snapcraft is rerunning the build step for that part again. But
cpwill refuse to overwrite the same file, and returns withexit 1; because of that nonzero exit code, snapcraft considers a step to have failed and stops the build.In this specific instance, overwriting is safe. Generally speaking, overwriting is usually the behavior you would want (for instance, many
Makefiles will usecp -f,rm -f,ln -f, etc.).