Right now, they're very different libraries. Conversation included below. Maybe we can add both to the website for now and remove one if/when they merge?
01:14 <rzr-M> Hi steven_
01:14 <steven_> hi
01:14 <rzr-M> Thx for trying webthingo
01:15 <rzr-M> I am on holidays now
01:16 <rzr-M> It Will be appriciated if u create a ticket About missing fematures you are implementing
01:16 <rzr-M> To avoid overlap
01:20 <rzr-M> I will be happy to merge stuff once back in oct
01:20 <steven_> 🤔
01:22 <rzr-M> Err: Missing features
01:24 <rzr-M> It would be nice to maintain a single repo
01:32 <rzr-M> Fragmentation is not desirable
01:33 <rzr-M> Please try to fork and rebase
01:33 <rzr-M> We can help here
01:39 <steven_> Actually, I didn't know you were working there before I started. So this is not a fork project, and I did most of the rest-api translation according to webthing-node/webthing-java. It's completely different from your own implementation. I want to push it to a project team at Mozilla, not an individual project.
01:43 <steven_> You are a good engineer, I really hope you can help to complete the last function, you can check Readme, most of the API has been completed. https://github.com/dravenk/webthing-go
01:44 <rzr-M> Hmm I see this more as a duplication of files (btw licence is missing)
01:44 <rzr-M> Well I have to go
01:45 <rzr-M> Try to rebase of my webthing go
01:45 <rzr-M> Then I am ok to xfer it elsewhere
01:45 <rzr-M> But not until october
01:45 <rzr-M> Good luck
02:05 <steven_> I don't understand why you said these are duplication of files. The implementation of value for the original nodejs/ Java version is very interesting. So I wrote the go version: https://github.com/dravenk/webthing-go/blob/master/value.go. There are the Actions/Events, etc. Why did you say duplication of files?
02:11 <rzr-M> Sorry I have to go , just rebase and let me check then I am ok to have it in moziot github .. just merge both
02:11 <rzr-M> Err I mean rebase
02:13 <rzr-M> https://www.slideshare.net/mobile/rzrfreefr/updownstreamflows20190411rzr
up-down-stream-flows-20190411rzr
02:13 <rzr-M> https://www.slideshare.net/rzrfreefr/updownstreamflows20190411rzr
up-down-stream-flows-20190411rzr
02:14 <rzr-M> Does this page load ?
02:14 <rzr-M> https://speakerdeck.com/rzr/up-down-stream-flows-20190411rzr
07:00 <mrstegeman> steven_: rzr-M: i see no problem with having both implementations. more implementations is almost always better, as it gives developers more choice and flexibility.
07:01 <mrstegeman> see https://github.com/mozilla-iot/mozilla-iot.github.io/pull/63
Add new Go library. by mrstegeman · Pull Request #63 · mozilla-iot/mozilla-iot.github.io
07:06 <steven_> Thanks for understanding 🙏
07:26 <mrstegeman> rzr-M: specifically, this is not a fork of your library, it's a separate implementation
07:42 <steven_> mrstegeman: The good news is that I've completed all of the Web Thing REST apis so far, and the bad news is that I still need to work on some details, such as data contention for Actions and documents.
10:04 <mrstegeman> steven_: if you implemented the examples identically to the other webthing libraries, you can use this to test: https://github.com/mozilla-iot/webthing-tester
11:49 <rzr-M> It's clear that its a derived work of mine
11:49 <rzr-M> Just look at readme
11:52 <mrstegeman> steven_ didn't know your library existed when he messaged us in here a couple weeks a go about his implementation. that's when i told him about yours.
12:21 <rzr-M> I dont believe this
12:21 <rzr-M> I wrote this:
12:21 <rzr-M> USAGE:
12:21 <rzr-M> To get started look at examplesdirectory:
12:24 <rzr-M> Well aģain just rebase .. I dont want To own anything... It is silly to not cooperate on this
12:25 <mrstegeman> i'll let you work it out with him. the code looks nothing alike and doesn't work the same, though, so it's not really possible to "just rebase"
16:56 <steven_> Thanks to checking the code base, this really isn't a fork of your webthing go. I asked benfrancis: on Wednesday, September 11t, and I didn't even know you were working on it. I'm sorry Readme confused you.
18:28 <rzr-M> Humm
benfrancis
commented
5 years ago
Right now, they're very different libraries. Conversation included below. Maybe we can add both to the website for now and remove one if/when they merge?