search

WebThingsIO / philips-hue-adapter

WebThings Gateway Philips Hue Adapter
Mozilla Public License 2.0
21 stars 12 forks source link

Support hue dimmer switches #32

Closed freaktechnik closed 6 years ago

freaktechnik commented 6 years ago

The dimmer switch support is far from optimal, since the hue API is polled every second, so presses are easily missed.

One possible "solution" for that would be to add an event for "missed presses" based on the last changed state property that lets us check if we potentially missed some presses, though we'll only know which button was let go last.

mrstegeman commented 6 years ago

@freaktechnik Would you mind separating the battery and the dimmer changes into separate PRs? I'm fine with the battery changes, but it would be better for @hobinjk to take a look at the dimmer changes and weigh in.

mrstegeman commented 6 years ago

@freaktechnik Can you resolve the conflict, please? I added @hobinjk as a reviewer for when he's available to look.