Add air quality monitor and smoke detector, improve energy monitor

WebThingsIO / schemas

A Web of Things schema repository

https://webthings.io/schemas/

5 stars 8 forks source link

Add air quality monitor and smoke detector, improve energy monitor #65

Closed enkiusz closed 4 years ago

enkiusz commented 4 years ago

Add an air quality monitor and smoke detector capabilities
Add a powerfactor property to the energy monitor
Most energy monitors measure real AC power, change the propery name to reflect that

Fixes #28 Fixes #38

tim-hellhake commented 4 years ago

Are you still working on this @mgrela?

enkiusz commented 4 years ago

Hi, sorry for the delay, stuff happened outside of GH. I posted the third round of changes with the suggestions implemented.

tim-hellhake commented 4 years ago

I'm glad to see that you are still working on it :)

mrstegeman commented 4 years ago

https://en.m.wikipedia.org/wiki/Pascal_(unit)#Hectopascal_and_millibar_units

benfrancis commented 4 years ago

@madb1lly Thanks for looking looking up the original source, the comment on ppm seems good enough to me! I guess Wikipedia is wrong.

Regarding μg/m3, for all the other units we use we write the long form rather than the abbreviated form so whatever we use it should really be consistent. What would be the valid long form of this unit? Also, m3 is presumably not the same thing as m³?

@mrstegeman Did you mean to post that link in #67?

madb1lly commented 4 years ago

Hi @benfrancis,

I think long form would be micrograms per cubic metre.

I don't think m3 works as a unit because it would mean 3m. But will the schema accept the Unicode superscript 3 character? Does it need the short version at all?

Cheers 🙂

mrstegeman commented 4 years ago

@benfrancis Yes... 😶

benfrancis commented 4 years ago

@madb1lly wrote:

I think long form would be micrograms per cubic metre.

Yep that looks right. Like "joule per cubic metre" for energy density.

So as long-winded as it is, "micrograms per cubic metre" seems like the consistent choice, and avoids the need for a superscript 3 :)

I created a pull request #68

mrstegeman commented 4 years ago

We handle conversions to the short form at the gateway level anyway, so a normal user should never see the long form.

benfrancis commented 4 years ago

You might be interested to know that the W3C WoT Working Group are discussing using SenML for the WoT "core profile", which seems more constrained than allowing any valid SI unit https://github.com/w3c/wot-profile/issues/29