search

WebThingsIO / thing-url-adapter

Proxy adapter for Web Thing API endpoints
Mozilla Public License 2.0
22 stars 18 forks source link

Remove stale things #9

Closed hobinjk closed 6 years ago

hobinjk commented 6 years ago

Instead of exiting if a url is known, check whether the downloaded thing descriptions are known and refresh the things if necessary.

Note that depending on the frequency of mDNS/Eddystone pings it makes more sense to drop knownUrls entirely and always refresh.

Fix #8.

There's still the issue I brought up in https://github.com/mozilla-iot/gateway/pull/755#discussion-diff-175197347L400 where you have to restart the Gateway to see a Thing if you remove it.

mrstegeman commented 6 years ago

@hobinjk I think the issue with the device not being found is add-on specific. I do see that issue with this add-on, but not with some others, like TP-Link. I think all that needs to happen is the mDNS browser just needs to be restarted in startPairing().

hobinjk commented 6 years ago

Review comments addressed