WebThingsIO / thing-url-adapter

Proxy adapter for Web Thing API endpoints
Mozilla Public License 2.0
22 stars 18 forks source link

Simplify auth lookups. #98

Closed mrstegeman closed 3 years ago

mrstegeman commented 3 years ago

@MarcGraham Can you confirm that this still works for you with your JWT devices?

@madb1lly Does this improve anything for you?

MarcGraham commented 3 years ago

@mrstegeman

This looks to be working fine for me. Thanks.

typh289 commented 3 years ago

I get this error on logs after addon update ERROR : thing-url-adapter: TypeError: Cannot read property 'replace' of undefined ERROR : thing-url-adapter: at ThingURLAdapter.loadThing (/etc/webthings-gateway/addons/thing-url-adapter/thing-url-adapter.js:549:27)

mrstegeman commented 3 years ago

v0.5.2 should fix the issue.

typh289 commented 3 years ago

yes fixed, thank you!

MarcGraham commented 3 years ago

@mrstegeman

Hi -- feel free to ping me if I can help test this.

MarcGraham commented 3 years ago

Hi, Looks like 5.2 breaks my jwt implementation. It looks like the auth strings can not be found.

Looks like it has to do with the upgrade bit for url strings? If I delete my auth entry on the adapter config page and re-add it seems to be working again.