search

WebThingsIO / webthing-arduino

Simple server for ESP8266, ESP32, Ethernet, or WiFi101-compatible boards compliant with Mozilla's proposed WoT API
Mozilla Public License 2.0
207 stars 78 forks source link

W3C compliance #139

Closed relu91 closed 3 years ago

relu91 commented 3 years ago

This PR belongs to the new plan of making webthings implementation aligned with the W3C Thing Description specification. Consider this as the first step towards full compliance. Nonetheless, we have already testest the change on actual devices and therefore we've updated the example section with (what we hope) useful guidelines.

Credits: Most of the works have been carried out by @Citrullin.

rzr commented 3 years ago

may this long serie can be upstreamed into smaller changes PR ?

Citrullin commented 3 years ago

may this long serie can be upstreamed into smaller changes PR ?

Well, I can make one PR for the compliance and one for the examples. But this would include the changes in ESPWebThingAdapter.h and Thing.h in one PR. I am also not sure, if the existing example would still work with that change. But, if you wish so and it helps, sure, I can do that.

relu91 commented 3 years ago

Well, I can make one PR for the compliance and one for the examples. But this would include the changes in ESPWebThingAdapter.h and Thing.h in one PR. I am also not sure, if the existing example would still work with that change. But, if you wish so and it helps, sure, I can do that.

I was thinking the same, but @rzr you have already a detailed commit history that you can navigate for reviewing. But yeah we can do a single PR containing only the alignments with w3c standard.

relu91 commented 3 years ago

Ok talked "offline" with @Citrullin, I'm closing this PR and he'll go on and open smaller PRs.

rzr commented 3 years ago

ok may it be reopened but I am a bit busy now so I can't do large review that said if you find more reviewers that are ok , I'll be happy to merge it.