search

WebThingsIO / wot-adapter

Proxy adapter for W3C compliant WoT devices
Mozilla Public License 2.0
2 stars 3 forks source link

Fix peers dep #9

Closed relu91 closed 3 years ago

relu91 commented 3 years ago

This PR adds the gateway-addon as a devDependecy. This is a pretty standard solution for getting around the fact that npm 6 does not automatically install peer depends after an npm install or npm ci, Since we are using gateway-addon types I think it makes sense to add it as a devDependecy too. When we'll migrate to npm 7 we might re-evaluate this decision.

Based on #8.

benfrancis commented 3 years ago

@relu91 I note that in the README of gateway-addon-node it says:

NOTE: This should NEVER be included as an add-on dependency, as that will cause breakages across gateway versions. The gateway will provide this dependency for every add-on. This package only exists to facilitate building the gateway itself.

What's your view on that? Should that warning be removed from the README if we're doing it for WebThings' own add-ons or is that a genuine problem and therefore we shouldn't be doing this?