Closed chas-iot closed 3 years ago
node.onOffProperty
is actually still used in some places. That doesn't seem to be the case for node.levelProperty
.type
isn't actually used anymore, so this commit will effectively do nothing.regarding node.type, it is still used to build the node.defaultName and node.name see ```zb-classifier
classify(node) {
...
// Now that we know the type, set the default name.
node.defaultName = `${node.id}-${node.type}`;
if (!node.name) {
node.name = node.defaultName;
}
regarding node.onOffProperty - oops, my fail, I thought I searched for this. It still needs a change - if there are multiple endpoints, I assume that the first endpoint should have precedence, not the last.
regarding node.type, it is still used to build the node.defaultName and node.name see ```zb-classifier
classify(node) { ... // Now that we know the type, set the default name. node.defaultName = `${node.id}-${node.type}`; if (!node.name) { node.name = node.defaultName; }
Ah, ok. Makes sense.
regarding node.onOffProperty - oops, my fail, I thought I searched for this. It still needs a change - if there are multiple endpoints, I assume that the first endpoint should have precedence, not the last.
Yes, probably the first should have precedence.
The Scenes buttons and property on the TRADFRI remote control are functional again. While working through I found a number of cleanups. I sequenced these into a series of commits from most straightforward through to possibly intrusive.
Therefore I suggest that this is reviewed on a commit by commit basis, rather than looking at the PR as a whole.