WebThingsIO / zwave-adapter

Z-Wave adapter add-on for WebThings Gateway
Mozilla Public License 2.0
15 stars 20 forks source link

Adding Support for Fibaro CO Sensor #76

Closed samgundel closed 4 years ago

samgundel commented 4 years ago

Value

Add missing features and resolves https://github.com/mozilla-iot/zwave-adapter/issues/72

image

Change of functionality:

We add support the following zwave properties of command classes 113 and 49:

- class 49 SENSOR_MULTILEVEL
  - CO Level
- class 113 ALARM
  - Heat

Notification Functionality

The sensor has 3 alarm functionalities:

Read-Only Functionality

dhylands commented 4 years ago

To run tests locally, you can do

npm run jest

You can run against an individiual .json file by doing:

npm run jest -- -t Fibaro-FGSD001-CO-Sensor.json

I should probably add a script called test which runs lint and jest (you can see them run individually at the end of the .travis.yml file).

samgundel commented 4 years ago

If you rebase against master and then do a forced push, it will just show your changes, rather than also showing the changes which were merged in.

If I rebase we kind of lose history and seems show up a bit messy on github. If the merge commits disturb in the end, I can rebase and force push when the change is ready to go in.

samgundel commented 4 years ago

Closing this and switching to Home Assistant.

mrstegeman commented 4 years ago

@jambuu sorry this got dropped!