Open muodov opened 2 years ago
We discussed this during the meeting on Jul 6th. At DDG, we hit quite a few limitations on different platforms, Apple providing the most features and Android having the most hard limits so far.
Injecting scripts is a powerful tool that can solve many different problems, and most of the underlying technology is already there for web extensions. My view is that ideally WebViews should expose more low-level and powerful modification features than browser extensions, since it is operating on the OS-native side of things. Besides, on Android and Windows there are alternative WebView implementations that can be more or less restrictive.
@rayankans would you mind sharing some perspective from the Chrome side? DuckDuckGo is struggling with some WebView limitations on Android, and it would be great to hear your opinion.
Thanks @muodov, agreed that having more control over the injection site would be useful.
The issue I brought up during the meeting was more on the API access level, not the API itself. I believe powerful APIs like JS injection should only be available for 1P web content, or failing that be gated by some form of user permission. That is however a separate issue altogether.
I was also wondering about the second point you made (injecting in cross-origin scripts). This seems somewhat related to issue #16 about blocking certain 3P scripts. Would that be enough or is there a use-case for being able to inject in cross-origin contexts?
@rayankans If I understood it correctly, #16 boils down to distinguishing injected scripts from the page scripts, and blocking based on that distinction. The second point of this issue is about being able to inject scripts at all. Indeed, our use-case requires injecting scripts in cross-origin iframes. Concrete examples from the top of my head:
These use-cases should not be bound by SOP, because these script injections don't originate from potentially untrusted web content, but from the user agent itself - the native app using WebView. Web extensions provide these possibilities even though they are just plugins to a user agent, but in case of WebView the embedding app acts as the user agent itself, and it seems strange that it's more limited in terms of content manipulation. Webkit exposes web extension abstractions for some time now, so we could probably look into how they address possible security concerns in this model.
@muodov Please take a look if PR #26 works for you.
Noting something I mentioned in the CG meeting last month - WebView2 on Windows doesn't treat 1P or 3P JS differently for this use-case, in a similar vein to what @muodov mentioned around originating from the user-agent. Totally possible that more locked-down mobile platforms have a different boundary, but for us if you're running a native app you could modify much of this in other ways (Fiddler being the easy example).
Inject custom JS scripts
Submitter(s)
Maxim Tsoy, Duck Duck Go
Motivation
User scripts (aka content scripts) is a powerful tool that unlocks many possibilities such as
Injected scripts can also be a workaround when another WebView feature is not available: for example, due to the lack of granular cookie control in native WebView APIs, DuckDuckGo injects a script to augment
document.cookie
API.There is a previously closed issue https://github.com/WebView-CG/usage-and-challenges/issues/10, which is similar, but here I try to expand the use case based on our experience.
Stakeholders
Analysis
Web extensions have a similar concept of content scripts, however the features provided by the native WebView implementaions are much less versatile and not standardized.
Most platforms implement a basic
evaluateJS(<string_payload>)
kind of method, which allows to execute arbitrary JS code in the page context. However, it is limited, and lacks some important features that would make developers live easier if they were cross-platform:1. Run scripts in isolated world
It is common for web pages to change JS prototypes and global variables. This can easily affect the scripts injected by the native app. This can lead to security and privacy issues, and is very hard to prevent. Isolated world prevents these collisions by running the content script within its own JS environment, while still allowing it to access the DOM. Moreover, scripts in isolated world are not affected by CSP and other restrictions imposed on the page scripts. To be clear, isolated world is not a replacement to the main world.
2. Inject scripts in all iframes, including cross-origin and sandboxed ones.
This is currently a serious limitation on Android, which only allows executing in same-origin contexts. For DuckDuckGo browsers, this makes it very difficult to apply tracking protections, since trackers often operate in a third-party context.
3. Inject scripts before all page scripts.
Web extensions have a "run_at" paramenter that controls when the script will be executed. This is crucial for any security and privacy customizations that need to apply protections before any malicious script can take effect. For example, DDG anti-fingerprinting protection augments the APIs, but it only protects from scripts executed after it.
4. Secure messaging between the native code and injected scripts.
Content scripts often work in combination with the native components and so require communication. For example, in DuckDuckGo browsers scripts use this to read user configuration (which is managed by the native app), and trigger native UI changes on page-generated events.
5. Inject scripts in ServiceWorkers and (Shared) Web Workers.
Some scripts are designed to change the JS environment of the page scripts. For example, DDG cookie protection deliberately changes the
document.cookie
API to protect against long-lived tracking cookies. However, there is currently no (straightforward) way to do this in Workers, which have access to powerful APIs as well (e.g. Cookie Store API)Related W3C deliverables and/or work items
WebExtensions CG
How is the issue solved in the Browser, and what’s more is needed?
In browsers, many of these issues are solved by Web Extension API. I think a lot of design patterns could be (and already are) borrowed from there. WKUserScript is clearly inspired by, and probably built upon the same technology.
However, just exposing the WebExtensions API might not always be the right solution: WebViews are embedded in native apps, which operate and protect under a different security and performance model. In general, WebView should probably give more raw control than WebExtensions API.