search

Webador / SlmMail

Send mail from Laminas or Mezzio using external mail services.
Other
106 stars 49 forks source link

AWS Sdk for PHP v3 support #105

Closed jackdpeterson closed 8 years ago

jackdpeterson commented 8 years ago

Resolves #90 and #103

jackdpeterson commented 8 years ago

A few things to note:

  1. This resolves some warnings from phpunit about the getMock versus createMock (the suggested way).
  2. I'm assuming that this will be a 2.0.0 tagged bump due to BC breakage.
  3. I'm assuming that setting the minimum to PHP 5.6 is perfectly acceptable because even phpunit complains about 5.5. Furthermore, major distributions of linux are now including php 7 at this juncture and providing legacy support for security-only versions of PHP is sub-optimal from a forward-looking perspective.
jackdpeterson commented 8 years ago

ping @bakura10 on merging this in

bakura10 commented 8 years ago

Looks pretty nice to me!

bakura10 commented 8 years ago

Tagged as 2.0.0.

Thanks!

jackdpeterson commented 8 years ago

Thanks for the quick merge :-)