search

Webador / SlmMail

Send mail from Laminas or Mezzio using external mail services.
Other
106 stars 49 forks source link

Add support for Mandrill subaccounts and Mailgun routes #46

Closed bakura10 closed 11 years ago

bakura10 commented 11 years ago

This PR adds a support to the newly added Mandrill subaccount features, and update the possible options.

It also adds support for Mailgun routes (which I didn't have the courage to do, but it's done now).

Can you review @juriansluiman? I'd suggest we tag this 1.1.0 as it adds quite a bunch of new features.

juriansluiman commented 11 years ago

Can you split the two features in two branches?

Furthermore, I would not update the README in this PR to suggest using 1.* as version constraint. I think it's good to tag 1.1.0 with these new features, but:

  1. I want to test the last sendgrid changes (from GET to POST or vice versa), because it worked before in my tests. Also, what happens now is iirc not according to the sendgrid docs (see here and here). I so will test the responses with the current version and the version prior to #42.
  2. Preparation of 1.1.0 tagging will happen in a release/prepare-1.1.0 branch where we set the version constraint from the README to >=1.1.0,<1.2.0-dev.

Because small BC breaks we don't notice can cause people a lot of problems, I advocate personally to always stick to minor releases unless you change your composer.json explicitly :)

bakura10 commented 11 years ago

I can break in two PR if you want, but I carefully test the features in Mandrill so I can assure you 100% they work as expected ;-).

+1, I'd like you to test SendGrid changes (especially with attachments).

I'm just going to change the Readme, if you really really need me to split I'll do it, but I don't think it's needed =).

bakura10 commented 11 years ago

I close as I separated it into two PR.