Metadata that is of an internal nature should have underscores

[basz]

As a side note, I think we should rename id to id and name to name when storing them in metadata. I know this is an annoying BC, though.

potential BC

SlmQueueXXXX's should do this too, then.

[bakura10]

ping @juriansluiman @basz

I know this is VERY annoying as this basically invalidates all old jobs, so that's why I think we should do this break as early as possible (and not wait that thousands of people use SlmQueue :D). We should either do that for 0.4 (it's pretty easy to do) or never do it as it will cause too much trouble if we wait too much.

[juriansluiman]

@bakura10 @basz I am back alive :)

1. True to change all those fields. However, content servers a userland purpose and metadata everything else (including internal info). So, if users need to store a name or id, they already should use content instead of metadata
2. It is not a big problem for BC breaks, since you likely update your jobs + dependencies at once. So if you have a queue running, usually you create a 2nd queue for this BC break. The "old" software completes the 1st queue, after which you shutdown that one and all new jobs will run on the 2nd queue without problems. At least, that's what you should do when working with queues on large scale :p

[basz]

@juriansluiman welcome back! Don't we have thousands of users then :-p I vote for do it now! If BC is a real concern, we could support both for 0.4.0 or 0.5.0 and remove the deprecated one in the release after that? If pressed an doctrine an upgrade script could be provided

[bakura10]

Ok, that sounds ok to me. Please review the other PR too ;). We'll need to update all the middleware accordingly to make sure we use id and not id!