search

Webador / SlmQueue

Laminas / Mezzio module that integrates with various queue management systems.
Other
137 stars 56 forks source link

Update to PSR-4 #118

Closed bakura10 closed 10 years ago

bakura10 commented 10 years ago

Update to PSR-4.

I know people don't like it (including myself), but I think we need to do the move.

@basz @juriansluiman ?

basz commented 10 years ago

No opinion. Care to motivate a bit? I thought psr4 introduces potential collisions.

Op 2 okt. 2014 om 18:59 heeft Michaël Gallego notifications@github.com het volgende geschreven:

Update to PSR-4.

I know people don't like it (including myself), but I think we need to do the move.

@basz @juriansluiman ?

You can merge this Pull Request by running

git pull https://github.com/juriansluiman/SlmQueue psr-4 Or view, comment on, or merge it at:

https://github.com/juriansluiman/SlmQueue/pull/118

Commit Summary

Update to PSR-4 File Changes

M composer.json (4) R src/Controller/AbstractWorkerController.php (0) R src/Controller/Exception/QueueNotFoundException.php (0) R src/Controller/Exception/WorkerProcessException.php (0) R src/Controller/Plugin/QueuePlugin.php (0) R src/Exception/BadMethodCallException.php (0) R src/Exception/ExceptionInterface.php (0) R src/Exception/RunTimeException.php (0) R src/Factory/JobPluginManagerFactory.php (0) R src/Factory/QueueControllerPluginFactory.php (0) R src/Factory/QueuePluginManagerFactory.php (0) R src/Factory/StrategyPluginManagerFactory.php (0) R src/Factory/WorkerFactory.php (0) R src/Job/AbstractJob.php (0) R src/Job/Exception/RuntimeException.php (0) R src/Job/JobInterface.php (0) R src/Job/JobPluginManager.php (0) R src/Queue/AbstractQueue.php (0) R src/Queue/Exception/RuntimeException.php (0) R src/Queue/Exception/UnsupportedOperationException.php (0) R src/Queue/QueueAwareInterface.php (0) R src/Queue/QueueAwareTrait.php (0) R src/Queue/QueueInterface.php (0) R src/Queue/QueuePluginManager.php (0) R src/Strategy/AbstractStrategy.php (0) R src/Strategy/AttachQueueListenersStrategy.php (0) R src/Strategy/Factory/AttachQueueListenersStrategyFactory.php (0) R src/Strategy/Factory/LogJobStrategyFactory.php (0) R src/Strategy/FileWatchStrategy.php (0) R src/Strategy/InterruptStrategy.php (0) R src/Strategy/LogJobStrategy.php (0) R src/Strategy/MaxMemoryStrategy.php (0) R src/Strategy/MaxRunsStrategy.php (0) R src/Strategy/ProcessQueueStrategy.php (0) R src/Strategy/StrategyPluginManager.php (0) R src/Worker/AbstractWorker.php (0) R src/Worker/WorkerEvent.php (0) R src/Worker/WorkerInterface.php (0)
Patch Links:

https://github.com/juriansluiman/SlmQueue/pull/118.patch https://github.com/juriansluiman/SlmQueue/pull/118.diff — Reply to this email directly or view it on GitHub.

bakura10 commented 10 years ago

I'm not sure. The thing is that PSR-0 is going to be deprecated soon. The question is do we either keep the top folder (in which case we just replace PSR-0 to PSR-4) or we take advantage of the flatter structure. I honestly don't like it too much because we loose the top namespace, but I'm pretty just most project will use this as it makes the structure simpler...

Regarding collisions, how can it happen? The SlmQueue is NOT removed from namespaces :)

bakura10 commented 10 years ago

I'm closing and deleting this branch for now as it seems it's the reason why Packagist fails.