Webador / SlmQueue

Laminas / Mezzio module that integrates with various queue management systems.
Other
137 stars 56 forks source link

Add new EMIT event #125

Closed bakura10 closed 10 years ago

bakura10 commented 10 years ago

ping @basz

Would this solve your issue?

bakura10 commented 10 years ago

The process is now:

A batchPop would be trivial: you get the jobs, and then trigger as many events as you have jobs.

bakura10 commented 10 years ago

I would be ok with that, but I still find "EMIT_JOB" (maybe better than just EMIT) more explicit than PROCESS_QUEUE. Although process_queue is more generic. I'll think about ti.

bakura10 commented 10 years ago

@basz I've fixed the code. Can you check the changes. It has some implications about what listener should listen to. I think in most cases it should listener to PROCESS_QUEUE (except for MaxRuns where it should be PROCESS_JOB). Can you verify it?

basz commented 10 years ago

Nice. Ill check tom morning. Thanks!

Op 5 okt. 2014 om 18:08 heeft Michaël Gallego notifications@github.com het volgende geschreven:

@basz I've fixed the code. Can you check the changes. It has some implications about what listener should listen to. I think in most cases it should listener to PROCESS_QUEUE (except for MaxRuns where it should be PROCESS_JOB). Can you verify it?

— Reply to this email directly or view it on GitHub.

bakura10 commented 10 years ago

Tests are passing again \o/

basz commented 10 years ago

@bakura10 things seem to work as expected in my project. Check the comments I made about the BatchProcessQueueStrategy and PROCESS_QUEUE vs PROCESS_JOB.

thumbsup

bakura10 commented 10 years ago

I'm going to tag as beta 2 unless you have anything more to do?

basz commented 10 years ago

i'm done.. thx!

bakura10 commented 10 years ago

Done!