Webador / SlmQueue

Laminas / Mezzio module that integrates with various queue management systems.
Other
137 stars 56 forks source link

Fix for composer php version including 7.0 #187

Closed TomHAnderson closed 8 years ago

basz commented 8 years ago

Hi Tom! What is this supposed to fix? Both notations allow for php7?

TomHAnderson commented 8 years ago

^5.5 fails for 5.6.

composer require slm/queue-doctrine
Using version ^0.6.1 for slm/queue-doctrine
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - This package requires php ^7.0 but your PHP version (5.6.20) does not satisfy that requirement.
TomHAnderson commented 8 years ago

The annotation for ^5.5 resolves to 7.0, I believe, and that's why we need ~5.3 || ^7.0 It'd be great to get these fixes in right away as I'm about to use Slm on yet another project.

basz commented 8 years ago

you mean >=5.5 fails on 5.6?. https://github.com/juriansluiman/SlmQueue/blob/master/composer.json#L25 that's weird...

AFAIK tag should become ^5.5 || ^7.0 which should work on 5.5, 5.6, 7.0, 7.1.

basz commented 8 years ago

but this always confuses the hell outa me...

here is test '>=1.0' which selects what i would expect : https://semver.mwl.be/#?package=bushbaby%2Fflysystem&version=%3E%3D1.0&minimum-stability=stable

here is test '^1.0' which also selects what i would expect : https://semver.mwl.be/#?package=bushbaby%2Fflysystem&version=%5E1.1&minimum-stability=stable

ps. using this package as php isn't a real package

TomHAnderson commented 8 years ago

I'll investigate that error a little more, brb

basz commented 8 years ago

if you would please. FYI I can run mkdir test && cd test && composer require slm/queue-doctrine without problems using php56

TomHAnderson commented 8 years ago

This was not a problem with slm. This was my problem for restricting PHP on my application composer.json and composer not telling me which package (the root one) required 7.0. I found this when I tried to install slm and saw the message.