search

Webador / SlmQueue

Laminas / Mezzio module that integrates with various queue management systems.
Other
137 stars 56 forks source link

InterruptStrategy.php replace declare ticks with pcntl_signal_dispatch #193

Closed basz closed 2 years ago

basz commented 7 years ago

declaring ticks is more expensive then pcntl_signal_dispatch

https://github.com/juriansluiman/SlmQueue/blob/a4f09a1c4dece7fd2d94498249affb8dea7e07b1/src/Strategy/InterruptStrategy.php#L60

roelvanduijnhoven commented 4 years ago

@basz Do you think this yields a serious improvement?

Also: can this be done in a minor version, or does this need a major bump?

basz commented 4 years ago

I’m reading it’s a non-negligible performance difference. Not sure into which numbers that would translate, but here is some info

https://weekly-geekly.github.io/articles/179075/index.html

https://blog.pascal-martin.fr/post/php71-en-other-new-things/

But yes, this could be changed at a later moment.

On 30 Jan 2020, at 16:20, Roel van Duijnhoven notifications@github.com wrote:

 @basz Do you think this yields a serious improvement?

Also: can this be done in a minor version, or does this need a major bump?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

roelvanduijnhoven commented 2 years ago

I'll close since there has been no activity lately. Obviously feel free to open a PR with such a feature :).