search

Webador / SlmQueue

Laminas / Mezzio module that integrates with various queue management systems.
Other
137 stars 56 forks source link

Do not require shared event manager if it not exists #201

Closed svycka closed 7 years ago

svycka commented 7 years ago

This allows using this module without zend-mvc.

svycka commented 7 years ago

@basz I think this way we will avoid BC break

basz commented 7 years ago

yep, how 'bout this https://github.com/juriansluiman/SlmQueue/blob/master/composer.json#L35 we can't move it to suggested without BC. Why is it in require-dev anyway?

svycka commented 7 years ago

I think if you use it with zend-mvc you still need this for controller and routes... also controllers should be tested not sure if they are :)

basz commented 7 years ago

Hi, are you able to test if the controllers are still compatible? If not I tag the next major version.

svycka commented 7 years ago

Should work and we have tests to confirm this so I guess it's ok

svycka commented 7 years ago

but for next major version I would go with symfony/console

basz commented 7 years ago

sure why not, you have time to do that?

svycka commented 7 years ago

don't have time now but when I have time why not unless you need it now. I am not sure how big this PR gonna be

basz commented 7 years ago

i don't have a need for it at this time, I don't really care bout which console to use.. :) But the cereal idea of decoupling as much as possible I like... so whenever to got time... Are you waiting on a tag with this PR in it?

svycka commented 7 years ago

I somehow workarounded this but yes tag would be nice :smile: