search

Webador / SlmQueue

Laminas / Mezzio module that integrates with various queue management systems.
Other
138 stars 57 forks source link

Feature/update to php72 #226

Closed basz closed 4 years ago

basz commented 4 years ago

branched of on #225

tooling PSR2 + PSR12 php72-74

roelvanduijnhoven commented 4 years ago

@basz The PR was fairly big due to code styling. I looked over the commits, and have no input at this point. Looks good to merge!

I'll test the library myself after this one has been merged.

basz commented 4 years ago

@basz The PR was fairly big due to code styling. I looked over the commits, and have no input at this point. Looks good to merge!

I know, sorry about that... :-)

I think the only real change was that due to return types the execute method of a Job now only return int or void. The annotations allowed for string, but really anything could be returned.

roelvanduijnhoven commented 4 years ago

@basz Feel free to merge!

I think the only real change was that due to return types the execute method of a Job now only return int or void. The annotations allowed for string, but really anything could be returned.

Let's list that in CHANGELOG.md as deprecation: Jobs that return anything other than an int or null, will fail in this new release.

basz commented 4 years ago

I've created a release as draft. The CHANGELOG.md is unused.