search

Webador / SlmQueueBeanstalkd

Beanstalkd adapter for SlmQueue module
Other
10 stars 26 forks source link

fix queue kick function #11

Closed jbaez closed 11 years ago

jbaez commented 11 years ago

After getting the queue from the Queue Manager, the kick function does not work as it does not have the tube name setted.

bakura10 commented 11 years ago

Looks sane for me. @juriansluiman is the guy for Beanstalkd.

However may we have a test for that @jbaez ? (just mock the Pheanstalk, and assert that useTube method is called with the right argument when kick)

juriansluiman commented 11 years ago

This is for now OK. Later on, the useTube command will be used when a tube configuration is specified in the queues config section. Than this might become obsolete, but for now it's the proper fix.

bakura10 commented 11 years ago

May I merge then?

juriansluiman commented 11 years ago

:+1: