search

Webador / SlmQueueBeanstalkd

Beanstalkd adapter for SlmQueue module
Other
10 stars 26 forks source link

Metadata is never used in pop() #33

Closed juriansluiman closed 10 years ago

juriansluiman commented 10 years ago 
return $this->createJob($data['class'], $data['content'], array('id' => $job->getId()));

See this and this comment.

juriansluiman commented 10 years ago

Proposed fix:

$metadata = array('id' => $job->getId()) + $job->getMetadata();
return $this->createJob($data['class'], $data['content'], $metadata);
kusmierz commented 10 years ago

@juriansluiman any chances to get this fix in stable version (ie. 0.3.1)?

juriansluiman commented 10 years ago

You are right, I have tagged v0.3.1 now. Get is while it's hot :fire:

kusmierz commented 10 years ago

Cool, thanks @juriansluiman !