bakura10
commented
10 years ago I'm checking that later tonight :)
Envoyé de mon iPhone
Le 5 mai 2014 à 20:32, Jurian Sluiman notifications@github.com a écrit :
This PR resolves issue #33. @bakura10 please review and merge if OK.
Another thing is that I am unhappy with the way we test now the system which relies on Pheanstalk. It just clutters the test enormously. Perhaps there is a solution to improve, @ocramius can you give a suggestion perhaps? Please check BeanstalkdQueueTest#testPopPreservesMetadata().
You can merge this Pull Request by running
git pull https://github.com/juriansluiman/SlmQueueBeanstalkd feature/pop-with-metadata Or view, comment on, or merge it at:
https://github.com/juriansluiman/SlmQueueBeanstalkd/pull/34
Commit Summary
Preserve metadata in job creation after pop() Test if metadata is preserverd Fix serialized issue due to metadata serialization File Changes
M src/SlmQueueBeanstalkd/Queue/BeanstalkdQueue.php (5) M tests/SlmQueueBeanstalkdTest/Controller/BeanstalkdWorkerControllerTest.php (2) M tests/SlmQueueBeanstalkdTest/Queue/BeanstalkdQueueTest.php (65) Patch Links:
https://github.com/juriansluiman/SlmQueueBeanstalkd/pull/34.patch https://github.com/juriansluiman/SlmQueueBeanstalkd/pull/34.diff — Reply to this email directly or view it on GitHub.
This PR resolves issue #33. @bakura10 please review and merge if OK.
Another thing is that I am unhappy with the way we test now the system which relies on Pheanstalk. It just clutters the test enormously. Perhaps there is a solution to improve, @ocramius can you give a suggestion perhaps? Please check BeanstalkdQueueTest#testPopPreservesMetadata().