search

Webador / SlmQueueBeanstalkd

Beanstalkd adapter for SlmQueue module
Other
10 stars 26 forks source link

Using PR for Pheanstalk that fixes Memory Issue #47

Closed eddiejaoude closed 10 years ago

bakura10 commented 10 years ago

Hhmm not a really good idea to depends on master on a stable library. Can't you simply force them to tag a new version?

eddiejaoude commented 10 years ago

Yes that is the plan, this is just a temporary solution for anyone who wants it. As it is a major blocker.

eddiejaoude commented 10 years ago

I have fixed it to a commit ondev-master

eddiejaoude commented 10 years ago

I removed the commit hash as it seemed to cause issues when overwriting the default repository source. I do not suggest merging this in, more for information .

eddiejaoude commented 10 years ago

But the memory leak in the pda/pheanstalk repo is a blocker for us & would need a proper solution ASAP

eddiejaoude commented 10 years ago

I will close this PR so no mistakes happens :)

juriansluiman commented 10 years ago

@eddiejaoude afaik there is the option in composer root packages to provide a package yourself and sort-of alias them? Then you can load a custom package with the fix and await the upstream packages to release it later on.

eddiejaoude commented 10 years ago

@juriansluiman :+1: Thanks, I tried that, as we have it on another repo, but I think because the names are different on Packagist & Github, something doesn't line up.

Ref: https://getcomposer.org/doc/articles/aliases.md

eddiejaoude commented 10 years ago

This has now been fixed in pda/pheanstalk v3.0.1