search

Webador / sendcloud

Provides a PHP client to interact with the SendCloud API in an object-oriented way.
MIT License
16 stars 15 forks source link

Postal code is not required for some countries #26

Closed lukas-jansen closed 11 months ago

lukas-jansen commented 1 year ago

For some countries (eg. United Arab Emirates), there are not using a postal code. Although it is marked as required in the docs. it is not

villermen commented 1 year ago

@lukas-jansen Thanks for the PR! Have you tested whether sending an empty string instead of null in these cases works? The house number logic only worked for empty strings too. Mentioning an empty string can be passed in the parameters would work just as well and doesn't open the door to accepting unintentional null arguments.

lukas-jansen commented 11 months ago

Yep, you're right. 👍