search

WebberZone / contextual-related-posts

Contextual Related Posts WordPress plugin
https://webberzone.com/plugins/contextual-related-posts/
38 stars 23 forks source link

blank_output is not of Boolean type anymore #133

Closed astappiev closed 3 years ago

astappiev commented 3 years ago

Describe the bug No text displayed when no related posts found.

To Reproduce Set "custom text output" when no related posts found in the admin panel.

Expected behaviour My custom text is displayed.

Additional context The blank_output can have two values and both of them will be resolved to an empty string, what is not expected. According to what I found in deprecated file, the value was of Boolean type, it explains why the type was expected here.

ajaydsouza commented 3 years ago

Thank you for this, please can you resubmit with the WPCS standards. So it will need to be with Yoda conditions and === E.g. ‘blank’ === $args...