search

WebberZone / contextual-related-posts

Contextual Related Posts WordPress plugin
https://webberzone.com/plugins/contextual-related-posts/
38 stars 23 forks source link

Block settings for number of posts not saving #167

Closed onetrev closed 2 years ago

onetrev commented 2 years ago

I'm using CRP in the WP Site Editor (Full Site Editing). When I try to edit the Number of Posts or Offset, I save the Site Template, and the values are still there but on the front end the number of posts displayed does not change.

If I refresh the page / navigate away and back to the template I'm editing in the Site Editor (i.e. Single Post template) then the original default values of 6 for Number of Posts and 0 for Offset is back again.

Also, a tiny other issue, so not worth probably creating another bug report, but the long line of text in the "Other Attributes" box creates horizontal scrollbars in the Block Settings area.

setting-does-not-apply-resets text-creates-scrollbar

WP 5.9.3 Gutenberg plugin (latest)

ajaydsouza commented 2 years ago

@onetrev Please can you tell me what theme you're using for FSE?

onetrev commented 2 years ago

Sorry, should have mentioned that. I'm working with FrostWP. https://frostwp.com/

ajaydsouza commented 2 years ago

Thanks. I need to figure out how to do the placeholder text - this is only an issue on non-single posts, right? Because on the single you'd see the related posts.

onetrev commented 2 years ago

No this is on the "Single Post" template. And it's like this because the Template editor doesn't load dynamic content. It's all layout stuff. I'm very new to FSE, but that's how I believe it works. That's why things like "Site Title" or "Site Content" in the screenshot above show up for their blocks, because they are dynamic. The placeholder of "Site Title" is just to show you it there. :)

ajaydsouza commented 2 years ago

One more (and hopefully last) question and I'll experiment. Which are the blocks you've used for title/content? Or if it is easier, is there a way to copy all content and paste it here so I can import it into my test install

onetrev commented 2 years ago

No worries. Those are core blocks, were just included in template in the theme. Also, in there are other core blocks like "Post Featured Image" (which I added), "Post Date" and so on. Hope that helps!

ajaydsouza commented 2 years ago

Please can you check out this beta release: https://github.com/WebberZone/contextual-related-posts/releases/tag/v3.2.3-beta2

This should fix both issues. The block now displays a placeholder if you're not editing a post or if no posts are available. Settings should also save.

onetrev commented 2 years ago

Tested and it's fixed. Works perfectly and looks good. Thank you many times over!

ajaydsouza commented 2 years ago

Thank you for confirming. I'll get this out.