Handling of empty arrays in list_of / list_of_objects rules

[amakhrov]

Fixes #17

[DanielHreben]

Well done, but I think we must leave copy of original LIVR test suite not modified. So, there is two ways:

• move this new test cases to separate suite
• extend upstream LIVR test suite by create merge request in LIVR specifications repo

[amakhrov]

Oh, I didn't realize it's shared between all implementations.

Yeah I believe it should become a part of this shared test suit. I'll create a PR there

Sent from my T-Mobile 4G LTE Device

-------- Original message --------

From: Dan notifications@github.com

Date:02/13/2016 12:34 PM (GMT-08:00)

To: WebbyLab/php-validator-livr php-validator-livr@noreply.github.com

Cc: amakhrov amakhrov@inbox.ru

Subject: Re: [php-validator-livr] Handling of empty arrays in list_of / list_of_objects rules (#18)

Well done, but I think we must leave copy of original LIVR test suite not modified. So, there is two ways: move this new test cases to separate suite extend upstream LIVR test suite by create merge request in LIVR specifications repo — Reply to this email directly or view it on GitHub.

[amakhrov]

@SDSWanderer The proposed change has been added to the LIVR test suit now: https://github.com/koorchik/LIVR/pull/28 I copied the exact test cases from that repo into this PR. Please note that apart from that the original test suit has some more changes. I didn't include them into this PR, since some tests fail on that. It needs a separate PR to fix those issues.

[DanielHreben]

I know about only one original LIVR test case which was modified in PHP implementation suit, and it's also related to handling empty lists. Please describe what your found in some issue.

Anyway, I think we must merge this changes @antonfin @koorchik

[amakhrov]

@SDSWanderer more details about the updated test suit in this issue: https://github.com/WebbyLab/php-validator-livr/issues/19

[amakhrov]

@SDSWanderer any update on that?

[DanielHreben]

Thank you, good job.