Open kaihendry opened 11 years ago
Add a check to verify the fetched git commit against https://github.com/Webconverger/webc/blob/master/root/.gnupg/pubring.gpg
The signing keys would be:
pub 1024D/64399BE2 2005-07-05 uid Kai Hendry <hendry@webconverger.com> uid Kai Hendry <hendry@iki.fi> sub 2048g/F3BDCC36 2005-07-05 pub 4096R/FAFE3F02 2012-02-18 uid Webconverger <staff@webconverger.com> sub 4096R/A5A41D0F 2012-02-18
So I doubt going forward we can use the github pull request flow (to master), since the merge would ideally be signed too.
I'm also thinking that we should maybe have a toggle not to do the verification? Perhaps 'noverify' ?
Btw we use https://github.com/Webconverger/webc.git by default, so our security at present isn't bad. This would be icing on the cake.
Add a check to verify the fetched git commit against https://github.com/Webconverger/webc/blob/master/root/.gnupg/pubring.gpg
The signing keys would be:
So I doubt going forward we can use the github pull request flow (to master), since the merge would ideally be signed too.
I'm also thinking that we should maybe have a toggle not to do the verification? Perhaps 'noverify' ?