search

Webconverger / webc

Webconverger's curated chroot from which updates originate
https://webconverger.org/upgrade/
73 stars 37 forks source link

Grab and drag - disable the "disable dragging on links" option #228

Open scottbambrick opened 8 years ago

scottbambrick commented 8 years ago

This option (on by default) prevents scrolling happening when the user tries to initiate a scroll on top of a link. This is particularly painful when a page is full of links (eg a menu or something)

As far as I can tell this option affects the blacklists used by GAD which can be found in gadDefaults.js. I think it just switches the 'on' property

I suggest adding another configuration flag for this option.

Hopefully someone out there can confirm this and get it changed for the next version of WC.

kaihendry commented 8 years ago

Hi Scott,

grabdrag is not on by default. Or are you saying once it's on, you can't scroll whilst a link is selected? Can you link gadDefaults.js. I am not sure what that is.

What is the configuration option you would like to see here exactly please?

Thanks!

scottbambrick commented 8 years ago

When grabdrag is enabled, WebConverger uses all the default settings for the Grab and Drag add-on.

One of those options is "disable dragging on links". Here's a screenshot of the option when the add-on is installed on a regular desktop version of Firefox:

image

That option makes it so that grabdrag ignores when the user tries to start a scroll on a link. Eg if I have a big picture on the page with a link on it and I try to scroll by starting the finger motion somewhere on that picture, it doesn't scroll. It's really annoying when there's a page full of links like a menu - virtually anywhere on the screen is a link and the user is often prevented from scrolling.

The option is enabled by default for some reason, and disabling it resolves it (and makes it behave more like any other touchscreen device).

I hunted through the add-on source and think I found the bit that needs to be changed in gadDefaults.js

The three 'hiddenBLx' lines need to be changed so that the links objects' 'on' value is set to true.

...{"id":"links","on":"true",...

That's what I've come up with anyway and it'd be good if someone else could have a look over it to confirm.

It'd make sense to me to make this the default setting in WC, but if you want people to have the option then you'd have to add another config option for us to use it.

Hopefully that makes a bit more sense?