WebexCommunity / webex-node-bot-framework

A framework for creating Webex Teams bots using node and express
MIT License
57 stars 48 forks source link

add FedRAMP environment support #77

Closed jeremywillans closed 2 years ago

jeremywillans commented 2 years ago
jeremywillans commented 2 years ago

@jpjpjp - Can you please review

jeffmars commented 2 years ago

@jeremywillans, I had to modify what you did in order for it to work. The FedRamp toggle was not being passed to the SDK properly so wasn't initializing using proper service URLs.

This is what I did in the framework.js file that allowed it to work correctly.

    let config = {
      config: {
      },
      credentials: {
        access_token: this.options.token
      }
    };
    // add fedramp param if defined
    if (this.options.fedramp) {
      config.config.fedramp = true;
    }

What I'm not sure of is if this will cause issues with other options. webhookUrl and port still work fine but not sure about the others.