search

WebexCommunity / webex-node-bot-framework

A framework for creating Webex Teams bots using node and express
MIT License
59 stars 49 forks source link

downgrade webex #79

Closed jeremywillans closed 2 years ago

jeremywillans commented 2 years ago

Downgrade webex to exact-version 2.4.2 due to reported issues with the Framework.

jeremywillans commented 2 years ago

@jpjpjp - for your review and approval

jpjpjp commented 2 years ago

LGTM. One question. How did you determine that 2.4.2 was the right version? Are you certain that this version supports the fedramp option that you added into the framework recently? Assuming so this is approved (if I can figure out how to approve on mobile!)

jeremywillans commented 2 years ago

2.4.2 fixes the Logger Proxy issue. 1.156 is where FedRamp support was introduced.

jpjpjp commented 2 years ago

@jeremywillans thanks for checking that. I updated the version number in version-history.md. I think this is good to commit!