search

Webhose / webzio-python

Webz.io Python SDK
https://webz.io
MIT License
42 stars 12 forks source link

update print to python 3 and schema to https #5

Open GeorgeK-zn opened 4 years ago

GeorgeK-zn commented 4 years ago

No worries. To be clear the only reason for this pull request is http schema. If you like I can change it so the user would have the option to choose http/s but truly I think that this is a bad idea. One might use this library for the first time without checking exactly what the code does and use it to search for some very sensitive information over say cyber API. What do you think?

idanmel commented 4 years ago

Hi Nescobar, That's a good idea. Maybe have HTTPS as the default, and give the user the option of using HTTP?

GeorgeK-zn commented 3 years ago

@idanmel I've thought about it and I think that there is no point in leaving the HTTP schema. With the provided services your customers may search for very sensitive data, and some of them are probably doing it right now over the clear web. I think it should be the other way around: you should help your users by enforcing them to use a more secure connection and if someone wants they'll be able to downgrade to HTTP after changing one line of code.

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information