Invalid return type in ImapProtocol::search()

Webklex / laravel-imap

Laravel IMAP is an easy way to integrate both the native php-imap module and an extended custom imap protocol into your Laravel app.

https://www.php-imap.com

MIT License

641 stars 182 forks source link

Invalid return type in ImapProtocol::search() #444

Closed ken717w closed 2 years ago

ken717w commented 2 years ago

Describe the bug In the class Webklex\PHPIMAP\Connection\Protocols\ImapProtocol, the return type of search() has been specified to array. However, $response is being returned if it has a falsy value, while the type of $response could be either array, bool or null according to requestAndResponse().

Screenshots

Desktop / Server (please complete the following information):

PHP: 7.4.30
webklex/laravel-imap: 4.0.0

Webklex commented 2 years ago

Hi @ken717w , many thanks for your report. Unfortunately this is the wrong repository. Please head over to https://github.com/Webklex/php-imap/issues/new?assignees=&labels=&template=bug_report.md

Many thanks & happy coding,