WeblateOrg / weblate

Web based localization tool with tight version control integration.
https://weblate.org/
GNU General Public License v3.0
4.33k stars 969 forks source link

Check "Mismatched full stop" gives false positive in Russian #11838

Open emmapeel2 opened 2 weeks ago

emmapeel2 commented 2 weeks ago

Describe the issue

Apparently you do not add a full stop after an ellipsis in Russian, so we should refine the check.

I already tried

Steps to reproduce the behavior

You can see an example string at https://hosted.weblate.org/translate/tor/tor-browser/tor-browser-user-manual/ru/?checksum=edf1c3c8f1716ac2 .

In Russian it is not needed to add that period.

Expected behavior

The 'Mismatched full stop' check should be adapted to this Russian grammar rule, and not get mad because there is no period on the translation.

Screenshots

No response

Exception traceback

No response

How do you run Weblate?

weblate.org service

Weblate versions

No response

Weblate deploy checks

No response

Additional context

No response

nijel commented 1 week ago

I have no clue about the rules in Russian about full stops and quotes, but I'm pretty sure that the referenced string doesn't use correct Russian quotes. That makes me unsure whether the author knows enough about Russian interpunction in other regards. Therefore, I'd like to see some reference that omitting stop is actually correct in this case before adjusting the check accordingly.

PS: In this particular case, the English string is wrong because the label is actually "Configure Connection…" and not "Configure Connection".

github-actions[bot] commented 1 week ago

This issue has been put aside. It is currently unclear if it will ever be implemented as it seems to cover too narrow of a use case or doesn't seem to fit into Weblate.

Please try to clarify the use case or consider proposing something more generic to make it useful to more users.